Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cicd): adding additional linters #10

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request includes several changes aimed at improving code quality and consistency across the project. The most important changes include the addition of new linters and linter settings in the configuration file, refactoring of some functions to use Go's any type instead of interface{}, and minor code simplifications.

Improvements to code quality:

  • .golangci.yaml: Added multiple linters and detailed linter settings to enforce code quality and consistency.

Refactoring for type consistency:

  • cmd_add.go, cmd_diff.go, cmd_pull.go, cmd_push.go, cmd_version.go: Updated the Execute methods to use the any type instead of interface{}. [1] [2] [3] [4] [5]

Code simplification:

  • cmd_add.go: Refactored the Execute method to use a switch statement for better readability and maintainability.
  • file_selector.go: Simplified the Update method by using a type assertion.
  • main.go: Added a nolint comment to suppress the gocritic linter warning for the main entry point of the application.

@Jacobbrewer1 Jacobbrewer1 marked this pull request as ready for review February 6, 2025 10:30
@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) February 6, 2025 10:30
@Jacobbrewer1 Jacobbrewer1 merged commit 1cd0ec7 into main Feb 6, 2025
5 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the chore/linters branch February 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant