Make exception handling simpler #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 5 +1
Lines 175 229 +54
Branches 3 7 +4
=====================================
+ Hits 175 229 +54
Continue to review full report at Codecov.
|
JSkimming
force-pushed
the
simplify-exception-handling
branch
3 times, most recently
from
6860e42 to
fd8b5d2
Compare
JSkimming
force-pushed
the
simplify-exception-handling
branch
from
fd8b5d2 to
fc45f51
Compare
JSkimming
force-pushed
the
simplify-exception-handling
branch
from
10a5079 to
b8c6a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #18 has requested better documentation on how to log exceptions. Looking at this, it's relatively complicated when having to implement the three methods of IAsyncInterceptor.
This PR is an investigation into a potentially easier solution.