SonarQube fixes

git-svn-id: https://josm.openstreetmap.de/svn/trunk@14108 0c6e7542-c601-0410-84e7-c038aed88b3b
JOSM · Aug 8, 2018 · 5014697 · 5014697
1 parent 10a565d
commit 5014697
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/org/openstreetmap/josm/gui/io/importexport/OsmChangeImporter.java b/src/org/openstreetmap/josm/gui/io/importexport/OsmChangeImporter.java
@@ -75,13 +75,13 @@ protected void importData(InputStream in, final File associatedFile, ProgressMon
         }
         if (!hasOsmData && !hasNotes) {
             // FIXME: remove UI stuff from IO subsystem
-            GuiHelper.runInEDT(() -> {
+            GuiHelper.runInEDT(() ->
                 JOptionPane.showMessageDialog(
                         Main.parent,
                         tr("No data found in file {0}.", associatedFile.getPath()),
                         tr("Open OsmChange file"),
-                        JOptionPane.INFORMATION_MESSAGE);
-            });
+                        JOptionPane.INFORMATION_MESSAGE)
+            );
         }
     }
 

diff --git a/src/org/openstreetmap/josm/gui/layer/gpx/ConvertToDataLayerAction.java b/src/org/openstreetmap/josm/gui/layer/gpx/ConvertToDataLayerAction.java
@@ -195,7 +195,7 @@ public DataSet filterDataSet(DataSet ds, List<String> listPos) {
          * @param listNeg The keys that were previously unselected
          * @return {@link TagConversionDialogResponse} containing the selection
          */
-        private TagConversionDialogResponse showTagConversionDialog(List<String> keys, List<String> listPos, List<String> listNeg) {
+        private static TagConversionDialogResponse showTagConversionDialog(List<String> keys, List<String> listPos, List<String> listNeg) {
             TagConversionDialogResponse res = new TagConversionDialogResponse(listPos, listNeg);
             String lSel = Config.getPref().get(GPX_SETTING + ".last", "all");
 

diff --git a/src/org/openstreetmap/josm/io/OsmJsonReader.java b/src/org/openstreetmap/josm/io/OsmJsonReader.java
@@ -138,7 +138,7 @@ private void parseWay(JsonObject item) throws IllegalDataException {
         parseWay(wd -> readCommon(item, wd), (w, nodeIds) -> readWayNodesAndTags(item, w, nodeIds));
     }
 
-    private void readWayNodesAndTags(JsonObject item, Way w, Collection<Long> nodeIds) {
+    private static void readWayNodesAndTags(JsonObject item, Way w, Collection<Long> nodeIds) {
         for (JsonValue v : item.getJsonArray("nodes")) {
             nodeIds.add(((JsonNumber) v).longValue());
         }