Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/wraper objectids #308

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Bugfix/wraper objectids #308

merged 5 commits into from
Aug 28, 2022

Conversation

JKHeadley
Copy link
Owner

Two primary fixes:

  • Support delete payload with rest call
  • properly handle objectIds in payloads

This also adds some more tests for better coverage.

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #308 (89625c1) into master (27c1233) will increase coverage by 2.02%.
The diff coverage is 100.00%.

❗ Current head 89625c1 differs from pull request most recent head bdd1f2a. Consider uploading reports for the commit bdd1f2a to get more accurate results

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   80.24%   82.27%   +2.02%     
==========================================
  Files          24       24              
  Lines        2809     2809              
==========================================
+ Hits         2254     2311      +57     
+ Misses        555      498      -57     
Impacted Files Coverage Δ
utilities/handler-helper.js 82.88% <100.00%> (+8.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JKHeadley JKHeadley merged commit 9ff1798 into master Aug 28, 2022
@JKHeadley JKHeadley deleted the bugfix/wraper-objectids branch August 28, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant