Windows on ARM Support #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the aarch64 library is added, this check is unnecessary.
|
@DevCharly ready for review 😄 |
- changed DLL filename from aarch64 to arm64 - publish ARM DLL to Maven Central
DevCharly
added a commit
that referenced
this pull request
Aug 5, 2023
, PR #707) built by GitHub Actions: https://github.com/JFormDesigner/FlatLaf/actions/runs/5771160235 locally signed Windows DLLs with FormDev Software GmbH code signing certificate
DevCharly
reviewed
Aug 5, 2023
| @@ -55,12 +55,12 @@ private static void initialize() { | |||
|
|
|||
| String classifier; | |||
| String ext; | |||
| if( SystemInfo.isWindows_10_orLater ) { | |||
| // Windows: requires Windows 10/11 | |||
| if( SystemInfo.isWindows_10_orLater && (SystemInfo.isX86 || SystemInfo.isX86_64 || SystemInfo.isAARCH64) ) { | |||
There was a problem hiding this comment.
Have re-added this check for platforms to be sure to exclude unknown platforms.
E.g. Windows 10 ARM 32 bit (not sure whether Java exists for this platform).
Theoretically Microsoft could port Windows to RISC-V in the future. We don't know 😺
There was a problem hiding this comment.
AFAIK the only time a Windows variant for ARM 32bit existed (except Windows Mobile) was Windows RT, which I think is safe to say dead. Never mind... Windows IoT Core does support ARM32. Still, Java is not supported on that platform. But yeah, I guess it wouldn't hurt to keep the check there. :-)
|
@syoon2 thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #443
This PR adds native library support for Windows on ARM.
Verification steps