Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorPane text color under dark theme #9

Closed
kirill-grouchnikov opened this issue Oct 17, 2019 · 7 comments
Closed

EditorPane text color under dark theme #9

kirill-grouchnikov opened this issue Oct 17, 2019 · 7 comments

Comments

@kirill-grouchnikov
Copy link

All text controls use light text color under dark theme except for JEditorPane

@DevCharly
Copy link
Collaborator

Hmm, looks good to me on Windows. What OS and Java version do you use?

@kirill-grouchnikov
Copy link
Author

Java 13 on macOS Mojave

@kirill-grouchnikov
Copy link
Author

Maybe this is only for HTML content:

        JEditorPane jep1 = new JEditorPane("text/html;", "Sample <b>content</b><br> <u>text</u>");

@DevCharly
Copy link
Collaborator

Yes, text color (and the font) for HTML content is wrong.

Many thanks for reporting.

@JFormDesigner
Copy link
Owner

thanks, fixed in 0.14

@DevCharly
Copy link
Collaborator

@kirill-grouchnikov after fixing this issue I had a look at SubstanceEditorPaneUI to see whether you're also using the JEditorPane.HONOR_DISPLAY_PROPERTIES client property, which is the case. Anyway, I've noticed that super.installListeners(); is invoked twice. Don't know whether this is intentional or a mistake...

https://github.com/kirill-grouchnikov/radiance/blob/master/substance/src/main/java/org/pushingpixels/substance/internal/ui/SubstanceEditorPaneUI.java#L131-L132

@kirill-grouchnikov
Copy link
Author

Thanks for catching that. No reason for double call. Will remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants