Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors in the tooltips of disabled buttons #15

Closed
lbalazscs opened this issue Oct 21, 2019 · 3 comments
Closed

Colors in the tooltips of disabled buttons #15

lbalazscs opened this issue Oct 21, 2019 · 3 comments

Comments

@lbalazscs
Copy link

I am using FlatDarculaLaf with version 0.14 from Maven, and I noticed that the tooltips of disabled buttons are using a bright yellow background and dark text, and this attracts the eye, while anything disabled should not attract it. The "real" Darcula from Intellij uses the same colors for tooltips of disabled buttons as for the enabled ones, and this is OK.

BTW the "real" Darcula has cool little triangles in the tooltip shapes pointing to the original mouse location, while FlatDarculaLaf doesn't have them, but this is not so important.

@DevCharly
Copy link
Collaborator

Thanks. This is a bug. Actually didn't know that tooltip can have different colors for disabled components. Using Swing since 20 years and still learning... 😉

Yes, the "real" Darcula tooltips look very nice, but I wanted to keep the initial implementation as simple as possible. Maybe I'll add them later...

JFormDesigner pushed a commit that referenced this issue Oct 21, 2019
- Improved styling of dark tooltips (darker background, no border).
- increased top and bottom margins
- use brighter color in light theme
- Fixed colors in tooltips of disabled components. (issue #15)
@JFormDesigner
Copy link
Owner

JFormDesigner commented Oct 21, 2019

thanks, fixed in 0.15

I've also improved the styling a little bit. Hope you like it.

@lbalazscs
Copy link
Author

The colors are great now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants