Resolve #52 and fixes. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTML renderer Inline, SideBySide and Unified return false when there's nothing to render. - Text renderer Context, InlineCli and Unified return false when there's nothing to render. Main renderer returns false when there's nothing to render. - Text renderer InlineCli renders line-ending `\n` instead of `PHP_EOL`. - Added missing docBlock content. - Updated docBlock of the SubRenderer Interface. - Added method Diff::isIdentical(). - Updated README.md to reflect Diff::isIdentical().
JBlond
reviewed
Jul 23, 2020
JBlond
reviewed
Jul 23, 2020
- Fixed calling Diff::getGroupedOpCodes() twice.
JBlond
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's nothing to render.
there's nothing to render.
Main renderer returns false when there's nothing to render.
\ninstead ofPHP_EOL.