inkcpp_test build error on M1/arm64 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the fail is caused by some kind of permission issue. Let's see if it works when I re-trigger the jobs. |
|
This is a known GitHub issue when issuing PRs from a fork. The failing action is trying to post a comment on this PR with the inkproof results but since it's running from a fork, the environment is read-only (despite the fact you're a collaborator on this project). Anyway, the builds are passing so that's good. |
|
Then we just need to verify that this fixes the compilation error for M1/arm64 chips. |
|
brwarner
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Catch dependency to fix compile error