Update to latest Bevy main 0.11 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to latest Bevy commit * Manually derive StageLabel * Do not pin the Bevy commit * Cargo.toml: point back at non-forked iyes_loopless Co-authored-by: Ida Iyes <[email protected]>
|
It's fine. I looked over it and did not notice any problems. I don't care very much about the quality of the We have plenty of time until the 0.11 release to nitpick if anything should be done differently. :) |
NiklasEi
added a commit
to NiklasEi/iyes_progress
that referenced
this pull request
Oct 21, 2023
* fix assets tracking logic * depend on bevy main * Udate to latest Bevy main; prep for 0.8 (IyesGames#16) * Update to latest Bevy commit * Manually derive StageLabel * Do not pin the Bevy commit * Cargo.toml: point back at non-forked iyes_loopless Co-authored-by: Ida Iyes <[email protected]> * loopless moved some things around * v0.4: Bevy 0.8 * refactor things conditional on loopless into separate files * implement "hidden progress" * abstract progress return types with a trait * add hidden progress to example * add dummy systems, they might be useful to someone * version bump to 0.5.0 * update to iyes_loopless 0.8 * version bump to 0.6.0 * bevy 0.9 compat * Mark progress plugin as not unique (IyesGames#18) * Version bump to 0.7.1 * unique name for each plugin instance (IyesGames#19) * add note about issue IyesGames#20 * Bump Bevy to main 0.11-dev --------- Co-authored-by: Ida Iyes <[email protected]> Co-authored-by: Niklas Eicker <[email protected]> Co-authored-by: Ida Iyes <[email protected]> Co-authored-by: François <[email protected]>
inodentry
added a commit
that referenced
this pull request
Feb 18, 2024
* Update to latest Bevy main 0.11 (#23) * fix assets tracking logic * depend on bevy main * Udate to latest Bevy main; prep for 0.8 (#16) * Update to latest Bevy commit * Manually derive StageLabel * Do not pin the Bevy commit * Cargo.toml: point back at non-forked iyes_loopless Co-authored-by: Ida Iyes <[email protected]> * loopless moved some things around * v0.4: Bevy 0.8 * refactor things conditional on loopless into separate files * implement "hidden progress" * abstract progress return types with a trait * add hidden progress to example * add dummy systems, they might be useful to someone * version bump to 0.5.0 * update to iyes_loopless 0.8 * version bump to 0.6.0 * bevy 0.9 compat * Mark progress plugin as not unique (#18) * Version bump to 0.7.1 * unique name for each plugin instance (#19) * add note about issue #20 * Bump Bevy to main 0.11-dev --------- Co-authored-by: Ida Iyes <[email protected]> Co-authored-by: Niklas Eicker <[email protected]> Co-authored-by: Ida Iyes <[email protected]> Co-authored-by: François <[email protected]> * Update to Bevy main 0.13 * Bump version for Bevy 0.13 * Bump Bevy dependency to 0.13 --------- Co-authored-by: José Pazos Pérez <[email protected]> Co-authored-by: Ida Iyes <[email protected]> Co-authored-by: Ida Iyes <[email protected]> Co-authored-by: François <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
bevy-mainbranch to match bevy 0.11-dev. Also forwards toiyes_progres/main.The most notable change is the deprecation of
add_systemin favor of a more generaladd_systemsthat takes the schedule as a first parameter #8079.Base sets are no longer needed and a lot of systems could be refactored to not use them and include clearer schedules. Despite not needing base sets,
ProgressSystemSetis kept asCheckProgressis very useful to run systems that read the progress status. Now it can be done with.afteras shown in the example.The one thing that is lost with #8079 is the ability to order between schedules: relevant comment. However, this does not seem very relevant and in my testing it didn't affect the results.
Thank you for this wonderful plugin and please let me know if there is anything you want me to do differently!