Skip to content

Commit

Permalink
Don't duplicate logs in TensorBoard and handle --use_env (huggingface…
Browse files Browse the repository at this point in the history
  • Loading branch information
sgugger authored and Iwontbecreative committed Jul 15, 2021
1 parent 72ccaad commit bf359f3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/transformers/integrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -604,9 +604,11 @@ def on_train_begin(self, args, state, control, **kwargs):
self.tb_writer.add_hparams(args.to_sanitized_dict(), metric_dict={})

def on_log(self, args, state, control, logs=None, **kwargs):
if state.is_world_process_zero:
if self.tb_writer is None:
self._init_summary_writer(args)
if not state.is_world_process_zero:
return

if self.tb_writer is None:
self._init_summary_writer(args)

if self.tb_writer is not None:
logs = rewrite_logs(logs)
Expand Down
6 changes: 6 additions & 0 deletions src/transformers/training_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,12 @@ class TrainingArguments:
)

def __post_init__(self):
# Handle --use_env option in torch.distributed.launch (local_rank not passed as an arg then).
# This needs to happen before any call to self.device or self.n_gpu.
env_local_rank = int(os.environ.get("LOCAL_RANK", -1))
if env_local_rank != -1 and env_local_rank != self.local_rank:
self.local_rank = env_local_rank

# expand paths, if not os.makedirs("~/bar") will make directory
# in the current directory instead of the actual home
#  see https://github.com/huggingface/transformers/issues/10628
Expand Down

0 comments on commit bf359f3

Please sign in to comment.