Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicator didn't show! #12

Closed
devabir93 opened this issue Jan 16, 2020 · 3 comments
Closed

indicator didn't show! #12

devabir93 opened this issue Jan 16, 2020 · 3 comments

Comments

@devabir93
Copy link

Hello, thank you for your nice lib, but I am having a problem that is indicator didn't show.
here is my snippet code.

            <com.github.islamkhsh.CardSliderViewPager
                android:id="@+id/viewPager"
                android:layout_width="match_parent"
                android:layout_height="@dimen/_150sdp"
                android:layout_marginTop="10dp"
                app:auto_slide_time="5"
                app:cardSlider_indicator="@+id/indicator"
                app:cardSlider_otherPagesWidth="24dp"
                app:cardSlider_pageMargin="12dp"
                app:cardSlider_smallScaleFactor="1" />

            <com.github.islamkhsh.CardSliderIndicator
                android:id="@+id/indicator"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_gravity="center"
                android:layout_marginTop="@dimen/_8sdp"
                app:defaultIndicator="@drawable/ic_slider_unselected"
                app:indicatorsToShow="3"
                app:selectedIndicator="@drawable/ic_slider_selected" />

i think there is nothing to do in java code, right?

@IslamKhSh
Copy link
Owner

There is no errors in your snippet so I think that the problem is in your parent ViewGroup ... make sure to set constrains to indicator if you use ConstraintLayout or RelativeLayout and also make sure that's the orientation is vertical if you use LinearLayout.

@devabir93
Copy link
Author

I am sure that everything is ok, actually, when I put a dummy data it showed but when I changed it to show from API it disappears!

IslamKhSh added a commit that referenced this issue Feb 27, 2020
@IslamKhSh
Copy link
Owner

fixed in v1.0.1

omtodkar pushed a commit to omtodkar/CardSlider that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants