Add images preview in edit mode plus add keydown cleanup #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionaru
reviewed
Sep 10, 2020
README.md
Outdated
| @@ -73,6 +73,8 @@ var easyMDE = new EasyMDE(); | |||
| </script> | |||
| ``` | |||
|
|
|||
| If you need to remove installed listeners (when editor not needed anymore), call `easyMDE.cleanup()` | |||
|
|
|||
There was a problem hiding this comment.
The placement of the documentation is a bit odd, in between the parts describing how to load the editor. Maybe move this to https://github.com/Ionaru/easy-markdown-editor#removing-easymde-from-text-area ?
src/js/easymde.js
Outdated
| @@ -2048,7 +2049,8 @@ EasyMDE.prototype.render = function (el) { | |||
| if (options.status !== false) { | |||
| this.gui.statusbar = this.createStatusbar(); | |||
| } | |||
| if (options.autosave != undefined && options.autosave.enabled === true) { | |||
| var autosaveEnabled = options.autosave != undefined && options.autosave.enabled === true; | |||
| if (autosaveEnabled) { | |||
There was a problem hiding this comment.
What's the purpose of this change?
There was a problem hiding this comment.
@Ionaru well basically I reused change listener, so reused this check, though you ar right, rolled back now
Ionaru
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Ionaru ,
thanks for taking a fork of this and continue working on it! Our team needs some lightweight embeddable markdown editor with good visual capabilities so we decided to take a fork from EasyMDE and will return the features to upstream if you have time to review/discuss it and will be ready to move in the same direction.
I started with a visualisation of images.
Here is a preview how it looks:
Same feature was in (https://stackedit.io/app), but that editor is very heavy/not embeddable and does not work on mobile when EasyMDE is neat and suites most needs.
My planned next actions: (optional setting for buttons which will be put on top of images - this would allow easily attach image editor/delete an image).