[Evaluation] [Performance] Ditch 'NamedDeBruijn' in favor of 'DeBruijn' #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
Evaluation
Performance
EXPERIMENT
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
2 similar comments
|
/benchmark validation |
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '5eb80f3fe3' (base) and '4a6c11ad07' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
WWWWAT hahaha |
|
Comparing benchmark results of 'validation' on '5eb80f3fe3' (base) and '4a6c11ad07' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '5eb80f3fe3' (base) and '4a6c11ad07' (PR) Results table
|
|
Those results look pretty conclusive! |
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '5eb80f3fe' (base) and '4a6c11ad0' (PR) Results table
|
|
OK, I'm a moron, |
|
/benchmark validation-full |
2 similar comments
|
/benchmark validation-full |
|
/benchmark validation-full |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-full' on '5eb80f3fe' (base) and '4a6c11ad0' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
WTF is going on in this PR
|
|
Comparing benchmark results of 'validation-full' on '5eb80f3fe' (base) and '4a6c11ad0' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-full' on '5eb80f3fe' (base) and '4a6c11ad0' (PR) Results table
|
And it is consistent, here's the second output:
and the third one:
It appears that this PR somehow slows down the evaluator, while speeding up preparation, hence why we see results all over the place. How can it possibly slow down the evaluator? I have no idea, but this is likely me screwing something up, because I can't think of a way to make things slower by removing redundant code. The experiment is over, so I'm closing this PR, but we need to make sure to investigate this weirdness in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how much these nasty name conversions cost us.