[Evaluation] [Performance] Tweak 'safeIndexOne' #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/evaluation/performance/tweak-safeIndexOne
branch
from
3d50fe5 to
1ec7b16
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/evaluation/performance/tweak-safeIndexOne
branch
from
1ec7b16 to
b5a6534
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
This reverts commit b5a6534.
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Click here to check the status of your benchmark. |
|
/benchmark validation |
|
Comparing benchmark results of 'validation' on 'c082e28591' (base) and '1448b2a7c8' (PR) Results table
|
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark lists |
1 similar comment
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'c082e28591' (base) and '1448b2a7c8' (PR) Results table
|
|
/benchmark nofib |
|
Click here to check the status of your benchmark. |
|
/benchmark lists |
|
/benchmark validation |
1 similar comment
|
/benchmark validation |
|
Comparing benchmark results of 'nofib' on '223cca3c6f' (base) and 'e939f7dcb5' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '223cca3c6f' (base) and 'e939f7dcb5' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '223cca3c6f' (base) and 'e939f7dcb5' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '223cca3c6f' (base) and 'e939f7dcb5' (PR) Results table
|
|
Well, seems like making it worker-wrapper-friendly allowed us to claw a few more percent out of cold GHC hands. Pretty great! |
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
zliu41
approved these changes
Nov 21, 2024
effectfully
deleted the
effectfully/evaluation/performance/tweak-safeIndexOne
branch
bezirg
reviewed
Dec 2, 2024
| safeIndexOneCont z f = findTree where | ||
| findTree :: RAList a -> Word64 -> b | ||
| -- See Note [Optimizations of safeIndexOneCont]. | ||
| findTree Nil !_ = z |
There was a problem hiding this comment.
Can you explain why you need to bang the wildcard here: findTree Nil !_ (amazing results btw)
There was a problem hiding this comment.
It's in the referenced Note:
Bangs in the local definitions of 'safeIndexOneCont' are needed to tell GHC that the functions are
strict in the 'Word64' argument, so that GHC produces workers operating on @Word64#@.
Otherwise GHC doesn't know that it can unbox the second argument.
bezirg
reviewed
Dec 2, 2024
Comment on lines
+881
to
+885
| Env.safeIndexOneCont | ||
| (throwingWithCause _MachineError OpenTermEvaluatedMachineError . Just $ Var () varName) | ||
| pure | ||
| varEnv | ||
| (coerce varIx) |
There was a problem hiding this comment.
Not that it matters, but place this change also on the SteppableCek (for trying to keep the code similar :D )
There was a problem hiding this comment.
Good point, thank you.
|
There is a criterion benchmark inside index-envs if you want to use it. I will try to run it myself to see the before and after numbers |
I personally don't really care. The CEK machine is significantly faster and that's enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just being curious.