Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethrow policy for 0.19 release #5076

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Rethrow policy for 0.19 release #5076

merged 2 commits into from
Feb 11, 2025

Conversation

coot
Copy link
Contributor

@coot coot commented Feb 11, 2025

Description

  • diffusion: IOError rethrow policy
  • ouroboros-network-0.19.0.3

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner February 11, 2025 16:44
crocodile-dentist
crocodile-dentist approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add changelogs

@coot coot force-pushed the coot/rethrow-policy branch from 59183aa to 93e24bf Compare February 11, 2025 16:51
@coot coot enabled auto-merge February 11, 2025 16:59
@coot coot disabled auto-merge February 11, 2025 16:59
@coot coot force-pushed the coot/rethrow-policy branch from 93e24bf to 2bb850d Compare February 11, 2025 17:00
@coot coot enabled auto-merge February 11, 2025 17:00
@coot coot merged commit d405f0e into release/ouroboros-network-0.19 Feb 11, 2025
12 checks passed
@coot coot deleted the coot/rethrow-policy branch February 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @crocodile-dentist