nix: optimize caching by delaying setGitRev and other nix fixes #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgi
requested review from
a team,
deepfire,
mgmeier and
fmaste
as code owners
jbgi
force-pushed
the
nix-caching-improvements
branch
from
7bd2a95 to
9101889
Compare
jbgi
changed the title
|
Cross referencing a different stream of thought/work that also tries to deal with "laconic commits" ending up invalidating cache (in that case) via Also https://tvl.fyi uses josh-project to isolate commit trees. I do see a potential future link here for |
jbgi
force-pushed
the
nix-caching-improvements
branch
4 times, most recently
from
75f405e to
bd1daa1
Compare
deepfire
approved these changes
Jan 11, 2023
michaelpj
reviewed
Jan 11, 2023
michaelpj
reviewed
Jan 11, 2023
michaelpj
reviewed
Jan 11, 2023
jbgi
force-pushed
the
nix-caching-improvements
branch
4 times, most recently
from
aa9522d to
1791c0c
Compare
Merged
|
could some on mac test that cardan-node static binary in |
jbgi
force-pushed
the
nix-caching-improvements
branch
2 times, most recently
from
a5a0fde to
d3dd3f5
Compare
jbgi
requested review from
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
other simplification/optimization: - remove generated project-packages-exes.nix (now at eval time) - move rewrite-libs to binary-release.nix: not needed and faster for normal builds - use haskell.nix project overlays to simplify access to components and alternative projects config (profiled, etc.). - filter src to avoid rebuilds for test that depends on $CARDANO_NODE_SRC
and use haskell.nix cabal.
jbgi
force-pushed
the
nix-caching-improvements
branch
3 times, most recently
from
879afe5 to
522bc93
Compare
(This should be FIXME)
Until `after` is properly supported.
jbgi
force-pushed
the
nix-caching-improvements
branch
from
522bc93 to
eaff1c9
Compare
|
bors try |
tryBuild succeeded: |
jbgi
force-pushed
the
nix-caching-improvements
branch
from
cace5f9 to
73a2769
Compare
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 24, 2023
4778: Nix fixes - 1.35 r=disassembler a=jbgi this is a backport of #4748. Co-authored-by: Jean-Baptiste Giraudeau <[email protected]> Co-authored-by: John Ky <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jan 24, 2023
4778: Nix fixes - 1.35 r=disassembler a=jbgi this is a backport of #4748. Co-authored-by: Jean-Baptiste Giraudeau <[email protected]> Co-authored-by: John Ky <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jan 24, 2023
4778: Nix fixes - 1.35 r=disassembler a=jbgi this is a backport of #4748. Co-authored-by: Jean-Baptiste Giraudeau <[email protected]> Co-authored-by: John Ky <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jan 24, 2023
4778: Nix fixes - 1.35 r=disassembler a=jbgi this is a backport of #4748. Co-authored-by: Jean-Baptiste Giraudeau <[email protected]> Co-authored-by: John Ky <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other simplification/optimization:
srcWith this, lots for derivation become much less sensible to rebuild for unrelated changes. It should also prevent lots of now unnecessary cache downloads, making cicero faster.
Also include a fix for hls (fixing
nix develop).