Refactor transaction build command #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/refactor-transaction-build-cmd
branch
from
1b834e3 to
15f3eb7
Compare
Jimbo4350
force-pushed
the
jordan/refactor-transaction-build-cmd
branch
3 times, most recently
from
8e10b06 to
dfad1c9
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy and
JaredCorduan
as code owners
catch-21
reviewed
Sep 15, 2022
Jimbo4350
requested review from
deepfire,
denisshevchenko and
jutaro
as code owners
Jimbo4350
force-pushed
the
jordan/refactor-transaction-build-cmd
branch
5 times, most recently
from
5efb1e3 to
23f6c04
Compare
Cardano.Api.Convenience.Query Cardano.Api.Convenience.Construction Cardano.Api.Convenience.Constraints This is the first stage of refactoring the transaction build command and simultaneously aims to expose a simplified interface to constructing and balancing a transaction. Move Cardano.CLI.Environment to Cardano.Api.Environment. We now reuse the SocketPath type throughout the cli and node
Remove SocketPath definition and textShow from cardano-submit-api Remove SocketPath definition from cardano-cli
Separate validation and construction of TxBodyContent Use queryStateForBalancedTx in runTxBuild Rename txInsExist to txInsExistInUTxO
Propagate textShow to cardano-cli Propagate textShow to cardano-node
Jimbo4350
force-pushed
the
jordan/refactor-transaction-build-cmd
branch
from
23f6c04 to
0ec700f
Compare
LudvikGalois
approved these changes
Sep 22, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 23, 2022
4446: Refactor transaction build command r=Jimbo4350 a=Jimbo4350 Co-authored-by: Jordan Millar <[email protected]>
|
bors r- |
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 23, 2022
4446: Refactor transaction build command r=Jimbo4350 a=Jimbo4350 Co-authored-by: Jordan Millar <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from JaredCorduan, dcoutts, deepfire, denisshevchenko, erikd, jutaro, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
erikd
approved these changes
Sep 23, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 23, 2022
4446: Refactor transaction build command r=Jimbo4350 a=Jimbo4350 Co-authored-by: Jordan Millar <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, denisshevchenko, jutaro, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Sep 23, 2022
|
bors merge |
|
Build succeeded: |
15 tasks
This was referenced Sep 26, 2022
Closed
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Sep 27, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.