Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script data deserialisation fix and properties #3860

Closed
wants to merge 4 commits into from
Closed

Script data deserialisation fix and properties #3860

wants to merge 4 commits into from

Conversation

sorki
Copy link
Contributor

@sorki sorki commented May 13, 2022

  • Adds roundtrips for CBOR and JSON ScriptData encoding
  • Improves generator to generate large numbers (negative and outside of Word64 bound)
  • Fixes deserialisation of ScriptData containing large numbers that were failing a superfluous bounds check

sorki added 4 commits May 12, 2022 18:19
@sorki
Add JSON roundtrip property for ScriptData
1023a7a 
using detailed schema.
@sorki
Add CBOR roundtrip property for ScriptData
5a8ef7a
@sorki
Improve genScriptData to generate larger range of numbers
96e420e 
for `ScriptDataNumber` constructor including numbers outside
`maxBound @Word64`.
@sorki
Remove bound check of ScriptDataNumber
e895122 
PlutusCore numbers are unbounded and this was only enforced
on deserialisation from JSON.

Also drops related `ScriptDataNumberOutOfRange` error.
@sorki sorki mentioned this pull request Aug 8, 2022
Closed
@newhoggy newhoggy mentioned this pull request Mar 19, 2023
Merged
@newhoggy
Copy link
Contributor

Replaced by #5002

@newhoggy
Copy link
Contributor

newhoggy commented Apr 2, 2023

Merged in other PR.

@newhoggy newhoggy closed this Apr 2, 2023
@newhoggy
Copy link
Contributor

newhoggy commented Apr 2, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorki @newhoggy