Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - Remove use of Haskell multi-line string literals #4585

Closed
newhoggy opened this issue Oct 31, 2022 · 5 comments · Fixed by #4889
Closed

[FR] - Remove use of Haskell multi-line string literals #4585

newhoggy opened this issue Oct 31, 2022 · 5 comments · Fixed by #4889
Assignees
@newhoggy
Labels
Stale type: enhancement An improvement on the existing functionality user type: internal Created by an IOG employee

Comments

@newhoggy
Copy link
Contributor

Internal/External
Internal

Area
Refactoring

Describe the feature you'd like
We sometimes use multi-line string literals in Haskell. This can play badly with other Haskell language features. We should avoid them and use string concatenation instead.

Describe alternatives you've considered
N/A

Additional context / screenshots
N/A
@newhoggy newhoggy added the type: enhancement An improvement on the existing functionality label Oct 31, 2022
@newhoggy newhoggy mentioned this issue Oct 31, 2022
Merged
@CarlosLopezDeLara
Copy link
Contributor

We should add this to https://github.com/input-output-hk/cardano-node/blob/master/STYLE.md

@CarlosLopezDeLara CarlosLopezDeLara moved this to 📋 Backlog (needs grooming) in Node CLI/API 2022 Oct 31, 2022
@CarlosLopezDeLara CarlosLopezDeLara moved this from 📋 Backlog (needs grooming) to 🔖 Sprint backlog in Node CLI/API 2022 Oct 31, 2022
@dorin100 dorin100 added the user type: internal Created by an IOG employee label Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Dec 2, 2022
@Jimbo4350
Copy link
Contributor

bump

@github-actions github-actions bot removed the Stale label Dec 10, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@newhoggy newhoggy mentioned this issue Jan 20, 2023
Merged
@newhoggy
Copy link
Contributor Author

bump

@newhoggy newhoggy mentioned this issue Feb 16, 2023
Merged
@iohk-bors iohk-bors bot closed this as completed in facefec Feb 19, 2023
newhoggy added a commit to IntersectMBO/cardano-cli that referenced this issue May 24, 2023
@iohk-bors @newhoggy
Merge #4889
77f68d6 
4889: Remove use of multiline literals r=newhoggy a=newhoggy

Also the style-guide in the Wiki has been updated with a new section: https://github.com/input-output-hk/cardano-node/wiki/Style-guide#multi-line-string-literals

Resolves IntersectMBO/cardano-node#4585

Co-authored-by: John Ky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newhoggy newhoggy

Labels
Stale type: enhancement An improvement on the existing functionality user type: internal Created by an IOG employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of multiline literals IntersectMBO/cardano-node
4 participants
@newhoggy @Jimbo4350 @dorin100 @CarlosLopezDeLara