Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future proof against extensions of TxBodyContent #785

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jun 7, 2024

Changelog

- description: |
    Future proof against extensions of TxBodyContent
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #784

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/treasury-donations branch 2 times, most recently from 2096e19 to b2b9781 Compare June 13, 2024 09:40
@smelc smelc force-pushed the smelc/future-proof-txbody-content-extensions branch from 6368754 to 680a70c Compare June 13, 2024 09:44
@smelc smelc force-pushed the smelc/future-proof-txbody-content-extensions branch from 680a70c to 09856b9 Compare June 13, 2024 13:44
@smelc smelc changed the base branch from smelc/treasury-donations to main June 13, 2024 13:44
@smelc smelc marked this pull request as ready for review June 13, 2024 13:44
@smelc smelc enabled auto-merge June 13, 2024 13:57
@smelc smelc disabled auto-merge June 13, 2024 14:41
@smelc smelc merged commit d39b778 into main Jun 13, 2024
10 checks passed
@smelc smelc deleted the smelc/future-proof-txbody-content-extensions branch June 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future proof against TxBodyContent extensions
2 participants