-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cardano-api to 8.45.0.0 #720
Conversation
dc01cae
to
45aab0d
Compare
This previous run shows that the new step |
45aab0d
to
68a627a
Compare
68a627a
to
0f0a8f1
Compare
|
||
-- | Test that converting a CC extended verification key yields the expected result. | ||
-- | Execute me with: | ||
-- @cabal test cardano-cli-golden --test-options '-p "/golden extended cc vkey to non extended vkey/"'@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not ideal to have these comments here as they can get out of sync with the function name.
Maybe it's worth modifying tast-discover
to include the option of reproducing the function name in the test name if that's what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like those comments, because they allow me to run one test without having to think about the complex shell command to enter. So far people received those new comments favorably, you're the first one to remark them 🙂 So I'm tempted to leave it here 😇
# This step is temporary. We'll soon remove it and check instead | ||
# that golden files have not been modified when creating them below. | ||
- name: Test all | ||
run: cabal test all --enable-tests --test-show-details=direct -j1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by the role this step has. Can you elaborate what problem you are solving with this temporary workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is more context here on Slack. Gist is that we were not checking that golden files are correct.
Changelog
Context
Fixes #705
Checklist