-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump consensus version bounds #487
Conversation
Bump deps version bounds Integrate changes
97d685d
to
75b2c37
Compare
I think this can be just a revision on CHaP |
CHaP release: IntersectMBO/cardano-haskell-packages#704 |
@@ -1,5 +1,14 @@ | |||
# Changelog for cardano-api | |||
|
|||
## 8.39.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why two version bumps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how Github shows the diff. Because this PR is based on 8.39.2. So it shows a weird diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this should be merged because the up to date version is 8.41... so I made an off branch CHaP release since it didn't have any major changes
@@ -1,5 +1,14 @@ | |||
# Changelog for cardano-api | |||
|
|||
## 8.39.3.0 | |||
|
|||
- Bump dependencies version bounds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you specify what was bumped here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouroboros-consensus-diffusion ^>= 0.12
Can you make another PR which branches off latest
I think this PR should be closed, because it bumps the API version to a lower than the one in |
@carbolymer yes I can do that. This is something I needed for 8.9.1 which uses cardano-api 8.39.2 . I didn't want to integrate/release latest cardano-api for 8.9.1, that will be done for 8.10. |
Done: #488 ! |
Changelog
Context
For node 8.9.1