Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump consensus version bounds #487

Closed
wants to merge 2 commits into from
Closed

Bump consensus version bounds #487

wants to merge 2 commits into from

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Mar 18, 2024

Changelog

- description: |
    Bump consensus packages version bounds
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

For node 8.9.1

Bump deps version bounds

Integrate changes
@bolt12 bolt12 force-pushed the bolt12/bump-deps branch from 97d685d to 75b2c37 Compare March 18, 2024 10:53
@bolt12
Copy link
Contributor Author

bolt12 commented Mar 18, 2024

I think this can be just a revision on CHaP

@bolt12
Copy link
Contributor Author

bolt12 commented Mar 18, 2024

CHaP release: IntersectMBO/cardano-haskell-packages#704

@@ -1,5 +1,14 @@
# Changelog for cardano-api

## 8.39.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two version bumps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how Github shows the diff. Because this PR is based on 8.39.2. So it shows a weird diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this should be merged because the up to date version is 8.41... so I made an off branch CHaP release since it didn't have any major changes

@@ -1,5 +1,14 @@
# Changelog for cardano-api

## 8.39.3.0

- Bump dependencies version bounds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify what was bumped here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouroboros-consensus-diffusion ^>= 0.12

@carbolymer
Copy link
Contributor

carbolymer commented Mar 18, 2024

Can you make another PR which branches off latest main which just contains:

  • Updated changelog - we would like to keep the log of all API releases
  • Dependecies' and indices' bump
  • Code changes

I think this PR should be closed, because it bumps the API version to a lower than the one in main and we don't want that.

@bolt12
Copy link
Contributor Author

bolt12 commented Mar 18, 2024

@carbolymer yes I can do that. This is something I needed for 8.9.1 which uses cardano-api 8.39.2 . I didn't want to integrate/release latest cardano-api for 8.9.1, that will be done for 8.10.

@bolt12
Copy link
Contributor Author

bolt12 commented Mar 18, 2024

Done: #488 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants