Use functions instead of pattern synonyms for ledger events #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jimbo4350
force-pushed
the
jordan/expose-remaining-existing-ledger-events-conway
branch
4 times, most recently
from
1a233e8 to
538266b
Compare
more easily digestible modules
Jimbo4350
force-pushed
the
jordan/expose-remaining-existing-ledger-events-conway
branch
from
538266b to
53615e8
Compare
Jimbo4350
changed the title
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer,
CarlosLopezDeLara and
disassembler
as code owners
Jimbo4350
force-pushed
the
jordan/expose-remaining-existing-ledger-events-conway
branch
from
53615e8 to
430bca3
Compare
carbolymer
reviewed
Dec 13, 2023
Jimbo4350
force-pushed
the
jordan/expose-remaining-existing-ledger-events-conway
branch
from
430bca3 to
130d3b7
Compare
…r events we want GHC will warn us when a new ledger event is introduced in cardano-ledger Create modules Cardano.Api.LedgerEvents.Rule.X based on the specific ledger rules from where these ledger events are emitted
Jimbo4350
force-pushed
the
jordan/expose-remaining-existing-ledger-events-conway
branch
from
130d3b7 to
97a2b29
Compare
carbolymer
approved these changes
Dec 13, 2023
Jimbo4350
deleted the
jordan/expose-remaining-existing-ledger-events-conway
branch
This was referenced Jan 2, 2024
Merged
2 tasks
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…UTxOCostPerWordFeature Delete `--utxo-cost-per-word`. No longer supporting this flag in any era going forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist