Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var guidance #141

Closed
Keboo opened this issue Jan 27, 2021 · 0 comments · Fixed by #162
Closed

var guidance #141

Keboo opened this issue Jan 27, 2021 · 0 comments · Fixed by #162
Assignees
@joeriddles
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Keboo
Copy link
Member

Keboo commented Jan 27, 2021 •
edited
Loading

Currently there is not guidance in the docs around var. With C# 9, this also somewhat expands to target-typed new expressions as well.

Previously the only written guidance was in Tom's blog.
We believe there should be some additional guidance provided here as well:

Both of the following should be put in a "Variables" section under "Coding"

  • CONSIDER using var any time that the initialization of the variable clearly shows what the variable will contain.
  • CONSIDER using target-typed new expressions any time that the instance clearly shows its type.
@Keboo Keboo added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 27, 2021
@joeriddles joeriddles linked a pull request Mar 19, 2021 that will close this issue
Closing #141 - var guidance #162
Merged
@joeriddles joeriddles self-assigned this Mar 19, 2021
@Keboo Keboo mentioned this issue Apr 23, 2021
Merged
Keboo pushed a commit that referenced this issue Apr 23, 2021
@joeriddles
Closing #141 - var guidance (#162)
777a37f 
* Add var guidance to xml

* Remove global.json

* Ignore vs vode .devcontainer

* Move XMLtoMD project

* Change Guideline to record from class

* Add GuidelineXmlToMD mstest project

* Implement GuidelineXmlFileReader test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeriddles joeriddles

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closing #141 - var guidance IntelliTect/CodingGuidelines
2 participants
@Keboo @joeriddles