Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Various fixes related to schema validation #963

Merged
merged 9 commits into from
Oct 15, 2024

Conversation

flochtililoch
Copy link
Collaborator

@flochtililoch flochtililoch commented Oct 14, 2024

Fix various issues related to schema validation, in particular due to our set up with 11ty:

  • Front matter ending up in generated XML files - this happens with files that were both destined to be served from their own endpoints but also included from other templates. To solve this, I created intermediate files for those that need to be served, and remove the front matter for those that are just included.
  • I've also updated the list of files in .eleventyignore to be explicit - this list represents all the templates that are meant to be included but should not be served as endpoints (hence not generated as static XML files). In the future, we will segregate private and public files to avoid the need to define this list.

Also in this PR:

  • remove exclusions from the XML validation command - now most generated templates are validated (the templates related to the share functionality, which uses an instawork namespace, is still ignored for now, it will be ported to a custom behavior in a future PR)
  • change the custom bottom bar component namepace prefix from instawork.com to hyperview.org
  • fix a few templates that would produce invalid XML
  • fix a few schema definitions that were incorrect

flochtililoch added 9 commits October 14, 2024 13:58
Remove most excluded path from schema validation, except for the share behaviors which should likely be moved to a custom behavior.
Although deprecated, bring back in sync with text-input
allow arbitrary strings - since IDs of navigators are not in the same doc.
These files are only meant to be included and should not generate static files (so they are not served nor XML validated). Ultimately we will want to segregate private and public files
@flochtililoch flochtililoch marked this pull request as ready for review October 14, 2024 23:53
@flochtililoch flochtililoch merged commit 68067f6 into master Oct 15, 2024
6 checks passed
@flochtililoch flochtililoch deleted the florent/fix-demo branch October 15, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants