feat(hv-navigator): Support for behaviors with on-event trigger
#946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2024 11:49
Allow adding event listeners via <behavior trigger="on-event" /> to the `<navigator>` tag. This is used to allow reloading a navigator from a event for example.
adamstep
approved these changes
Sep 27, 2024
| } | ||
|
|
||
| componentWillUnmout = () => { |
There was a problem hiding this comment.
Looks like a typo on the function name here.
hgray-instawork
added a commit
that referenced
this pull request
Oct 8, 2024
Resolve typo in function name Relates to: #946 (review) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected the spelling of the `componentWillUnmount` method in the `HvNavigator` class to ensure proper functionality upon component unmounting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to install event listener on the
<navigator>tag, for example to allow reloading the navigator document upon certain event occurring.