Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring of FullRepoManager #750

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

MapleCCC
Copy link
Contributor

This pull request should fix #749.

The render error originates from how we violate the syntax rules of the `field list` markup element of reStructuredText. The `specification of field list states](https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#field-lists) that a multi-line `field body` must be indented relative to the `field marker`.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2022
@MapleCCC
Copy link
Contributor Author

The CI errors originates from installing lxml, which is infamously difficult, when lxml not yet publishes wheel for CPython3.11+Windows.

These lxml-related CI errors are safe to ignore for our case here.

@zsol
Copy link
Member

zsol commented Aug 17, 2022

Thank you!

@zsol zsol merged commit 73cfc7f into Instagram:main Aug 17, 2022
@MapleCCC MapleCCC deleted the fix-fullrepomanager-docstring branch August 18, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FullRepoManager document has mild render error
3 participants