[native] make sure ParserError's line is zero-indexed #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 246 246
Lines 25607 25608 +1
=======================================
+ Hits 24279 24280 +1
Misses 1328 1328
Continue to review full report at Codecov.
|
lpetre
reviewed
May 3, 2022
| let kwargs = [ | ||
| ("message", e.to_string().into_py(py)), | ||
| ("lines", lines.into_py(py)), | ||
| ("raw_line", line.into_py(py)), | ||
| ("raw_line", (line + 1).into_py(py)), | ||
| ("raw_column", col.into_py(py)), |
There was a problem hiding this comment.
Is column zero or one based?
lpetre
approved these changes
May 3, 2022
|
should be 0-indexed Lines 115 to 117 in 6e0c63a |
1 task
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ParserErrorraised from the peg parser has 0-based line indices, but its__str__implementation expects it to be 1-based. This causes exceptions while trying to render theParserErrorexception.Fixes #678.
Test Plan
Added tests to verify
str()doesn't blow up.