Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port pyre fixes #651

Merged
merged 7 commits into from
Feb 18, 2022
Merged

Port pyre fixes #651

merged 7 commits into from
Feb 18, 2022

Conversation

stroxler
Copy link
Contributor

@stroxler stroxler commented Feb 18, 2022

Summary

Because it isn't feasible to continuously push new releases of LibCST, we vendored a copy of
_apply_type_annotations.py into the pyre codebase so that we could rapidly improve pyre infer.

But as a result several bugfixes have wound up in pyre that belong here. This commit closes the
gap.

Each commit is either:

  • a test harness commit, setting up (undesirable) test results that we'll fix in the next, or
  • a port from a change made to pyre, whose commit message points to the original commit

Test Plan

> python -m unittest libcst.codemod.visitors.tests.test_apply_type_annotations
.....................................................................
----------------------------------------------------------------------
Ran 69 tests in 7.039s

OK

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #651 (e32ec57) into main (f2cd39c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         247      247           
  Lines       25376    25378    +2     
=======================================
+ Hits        24052    24054    +2     
  Misses       1324     1324           
Impacted Files Coverage Δ
...emod/visitors/tests/test_apply_type_annotations.py 100.00% <ø> (ø)
libcst/codemod/visitors/_apply_type_annotations.py 95.45% <100.00%> (+<0.01%) ⬆️
libcst/metadata/tests/test_scope_provider.py 99.88% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2cd39c...e32ec57. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants