-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix space validation for AsName and Await #641
Conversation
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 245 245
Lines 25281 25297 +16
=======================================
+ Hits 23963 23979 +16
Misses 1318 1318
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Whoops, looks like there's a type check error. I'm not immediately seeing the cause, it doesn't seem to be on a line changed by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found the typecheck problem, once that's patched we should be good to merge.
hehe thanks! |
Summary
Fixes #633. Unfortunately we have to move the validation of
AsName
to its parent because of different rules for different parents as well as the need for the preceding expression.Test Plan
Added unit tests.