feat: codelists endpoints #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.12.0-SNAPSHOT deployed on docker hub |
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.12.0-SNAPSHOT.1 deployed on docker hub |
src/main/java/fr/insee/pogues/service/QuestionnaireService.java
Outdated
Show resolved
Hide resolved
Comment on lines
30
to
33
| @BeforeEach | ||
| void initQuestionnaireService(){ | ||
| questionnaireService = new QuestionnaireService(); | ||
| } |
There was a problem hiding this comment.
Vous faites pas du Mockito pour les Tests Unitaires ?
src/test/java/fr/insee/pogues/service/QuestionnaireServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/fr/insee/pogues/service/QuestionnaireServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/fr/insee/pogues/service/QuestionnaireServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/fr/insee/pogues/service/QuestionnaireServiceTest.java
Outdated
Show resolved
Hide resolved
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.12.0-SNAPSHOT.3 deployed on docker hub |
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.12.0-SNAPSHOT.4 deployed on docker hub |
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.12.0-SNAPSHOT.5 deployed on docker hub |
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.12.0-SNAPSHOT.6 deployed on docker hub |
|
|
||
| @Service | ||
| @Slf4j | ||
| public class CodesListService { | ||
| private QuestionnairesService questionnairesService; | ||
| private VariableService variableService; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
Plus besoin du @Autowired comme tu utilises déjà l'injection par constructeur. tu eux remove
Suggested change
| @Autowired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il reste une couche de test 🙄 à ajouter, mais c'est fonctionnel 🚀
Autre préciser: On supprime et on envoie un message à l'utilisateur
Reste à faire: