feat: improve contact endpoints for management front #82
Conversation
| HttpHeaders responseHeaders = new HttpHeaders(); | ||
| responseHeaders.set(HttpHeaders.LOCATION, | ||
| ServletUriComponentsBuilder.fromCurrentRequest().toUriString()); | ||
| return ResponseEntity.status(HttpStatus.CREATED).headers(responseHeaders) |
There was a problem hiding this comment.
why setting response headers here ? The method could return void, and set the created http status in an annotation
| }) | ||
| public ResponseEntity postSurveyUnitComment(@PathVariable String id, @Valid @RequestBody SurveyUnitCommentInputDto surveyUnitCommentDto) { | ||
|
|
||
| SurveyUnit surveyUnit = surveyUnitService.findbyId(id); |
There was a problem hiding this comment.
setting entity in the controller, why setting comments in the survey unit object ?
|
|
||
| String getIdSu(); | ||
| String getIdentificationCode(); | ||
| String getIdentificationName(); |
There was a problem hiding this comment.
why an interface for this ?
There was a problem hiding this comment.
Passing through an interface acts as a converter between my SearchSurveyUnitDto and the result of my query.
| @RequestParam(required = false) String identificationName, | ||
| public Page<SearchSurveyUnitDto> searchSurveyUnits( | ||
| @RequestParam(required = true) String searchParam, | ||
| @RequestParam(required = true) @Valid @ValidSurveyUnitParam @Schema(description = "id or code or name")String searchType, |
There was a problem hiding this comment.
does it work without @validated on the controller class ?
There was a problem hiding this comment.
the @validated annotation is present on the controller. And it does not work if I remove it
| @RequestParam(required = false) String identificationName, | ||
| public Page<SearchSurveyUnitDto> searchSurveyUnits( | ||
| @RequestParam(required = true) String searchParam, | ||
| @RequestParam(required = true) @Valid @ValidSurveyUnitParam @Schema(description = "id or code or name")String searchType, |
There was a problem hiding this comment.
It should be working without custom annotations here by giving directly the enum as parameter
There was a problem hiding this comment.
Same goes for the other custom validator annotation
There was a problem hiding this comment.
The annotation allows to customize the error message and also ignore the case passed in the parameter. I don't know if this is possible without the custom annotation?
|
No description provided.