Add Webhook adaptor #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dub.sdl
Outdated
| @@ -8,13 +8,12 @@ targetPath "out/" | |||
| dependency "inmath" version="~>1.0.2" | |||
| dependency "vmc-d" version="~>1.1.2" | |||
| dependency "fghj" version="~>1.0.0" | |||
| dependency "vibe-d:http" version="~>0.9.4" | |||
|
|
|||
| configuration "default" { | |||
| targetType "library" | |||
| } | |||
|
|
|||
| configuration "jml" { | |||
There was a problem hiding this comment.
maybe rename jml to something more descriptive.
maybe web-adaptors
There was a problem hiding this comment.
I was thinking that it made sense to change it to something like "vibe-d" or "http-adaptors" or something, i'll go with web-adaptors :)
There was a problem hiding this comment.
"jml" is the short tag for "JinsMemeLogger"
I assume that when someone decided to turn on jml adaptor, this configuration is specified from outside.
If these modules are merged as a default option, maybe just moving configurations to top level is good way, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was based on the JimsMeme Logger adaptor.
The purpose of this adapter is to enable to trigger blendshapes through http requests.
It opens a webserver on the configured port (default 8080) and listens the following endpoint.
POST /blendshapes : Expects application/json message with the list of blendshapes to trigger.
Example: