-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link to GitHub GQM graph page #53
Conversation
rrrutledge
commented
Oct 23, 2023
•
edited
Loading
edited
- The graph links only work in GitHub.
- Because of that we want to have a link in the book back to GitHub.
- For some reason the link in the book points to the page in the book.
- Maybe GitBook is auto-replacing GitHub links to point to the corresponding GitBook page instead.
- Hopefully this Bitly link won't get so-replaced.
* The graph links only work in GitHub. * Because of that we want to have a link in the book back to GitHub. * For some reason the link in the book points to the page in the book. * Maybe GitBook is auto-replacing GitHub links to point to the corresponding GitBook page instead. * Hopefully this Bitly link won't get so-replaces.
An easier way to try this out would be to make the change in app.gitbook.com direct, I think they call it a change request, and then discard that again. |
Btw I think this is a shortcoming of the mermaidjs integration in gitbook. So my suspicion is that you won't be able to fix this. |
OK check this out: https://app.gitbook.com/o/-MBYS3fpZ77O90pglFWi/s/-M3b_yGIW5Sz9pObaJm5/~/diff/~/changes/6/measuring/goals/use_gqm |
Ah. I had misunderstood this PR. Thought it was about changing the links that are embedded within the graph. About the issueWhen gitbook sees a link that it already knows from the From https://github.com/InnerSourceCommons/managing-inner-source-projects/blob/master/measuring/use_gqm.md So if you want to force a link back to the original markdown file, then your approach with a bitly link should work. As an aside:I cannot see the bitly link in your change request in gitbook. For me it still looks like you are pointing to https://github.com/InnerSourceCommons/managing-innersource-projects/blob/main/measuring/use_gqm.md. However that link does magically work right now, as we renamed Will file a separate issue/PR to change all links embedded in the content from |
OK let’s just go with this Bitly approach, then? |
Why don't we get previews on pull request for what our GitBook looks like? https://docs.gitbook.com/integrations/git-sync/github-pull-request-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets try bitly