Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Model API to OpenModel #76

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Change Model API to OpenModel #76

merged 1 commit into from
Aug 10, 2024

Conversation

kerthcet
Copy link
Member

What this PR does / why we need it

OpenModel is mostly open sourced models, they're clustescoped. However, we have may namespaced Model as well.

Which issue(s) this PR fixes

Fixes #33

Special notes for your reviewer

Does this PR introduce a user-facing change?

API change as Model is changed to OpenModel

@kerthcet
Copy link
Member Author

/kind feature
/api change

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 10, 2024
@kerthcet kerthcet force-pushed the feat/change-to-openmodel branch 3 times, most recently from fa40d92 to 4efede5 Compare August 10, 2024 15:38
@kerthcet kerthcet force-pushed the feat/change-to-openmodel branch from 4efede5 to a8e207b Compare August 10, 2024 15:50
@kerthcet
Copy link
Member Author

/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2024
@kerthcet
Copy link
Member Author

/api change

@InftyAI-Agent InftyAI-Agent merged commit 79d070c into InftyAI:main Aug 10, 2024
19 checks passed
@kerthcet kerthcet deleted the feat/change-to-openmodel branch August 10, 2024 15:55
@kerthcet kerthcet changed the title Change API Model to OpenModel Change Model API to OpenModel Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model should be namespaced
2 participants
@kerthcet @InftyAI-Agent