Feature: VSDSPUB-349: Add Gone status to soft deleted fragments #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WLefever-Cegeka
force-pushed
the
feature/VSDSPUB-349-gone-http-status
branch
from
9a48041 to
2e768c1
Compare
WLefever-Cegeka
force-pushed
the
feature/VSDSPUB-349-parent-updater-impl
branch
7 times, most recently
from
558c8d6 to
7c02842
Compare
WLefever-Cegeka
force-pushed
the
feature/VSDSPUB-349-gone-http-status
branch
2 times, most recently
from
766eedd to
adf29cb
Compare
Base automatically changed from
feature/VSDSPUB-349-parent-updater-impl
to
main
November 17, 2022 11:23
WLefever-Cegeka
force-pushed
the
feature/VSDSPUB-349-gone-http-status
branch
4 times, most recently
from
93c668a to
096003d
Compare
WLefever-Cegeka
force-pushed
the
feature/VSDSPUB-349-gone-http-status
branch
from
096003d to
4ac3880
Compare
WLefever-Cegeka
requested review from
Yalz,
rorlic,
tomvda and
sverholen
as code owners
sverholen
approved these changes
Nov 17, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Yalz
approved these changes
Nov 17, 2022
| @@ -21,7 +21,7 @@ Optional<LdesFragment> retrieveMutableFragment(String viewName, | |||
|
|
|||
| Optional<LdesFragment> retrieveRootFragment(String viewName); | |||
|
|
|||
| Stream<LdesFragment> retrieveImmutableFragmentsOfView(String viewName); | |||
| Stream<LdesFragment> retrieveNonDeletedImmutableFragmentsOfView(String viewName); | |||
There was a problem hiding this comment.
Got to say I find this rename more confusing.. I'd keep it at retrieveImmutableFragmentsOfView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.