feat: Split upload queue in two behind a new service #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
feat/split-upload-queue
branch
from
3dcb3bf to
c66db3b
Compare
adrien-coye
force-pushed
the
feat/split-upload-queue
branch
from
c66db3b to
955ad0e
Compare
adrien-coye
force-pushed
the
feat/split-upload-queue
branch
from
05bd211 to
580f3ce
Compare
… previously on the common queue
…l an upload to the service instead of the queue
…atabase code to the service
…tabase work is done in the service instead
|
adrien-coye
changed the title
adrien-coye
commented
Mar 12, 2025
|
|
||
| // TODO: Add to the correct queue |
| lazyCollection.filter("id IN %@", batchArray).freezeIfNeeded() | ||
| } | ||
| for file in matchedFrozenFiles { | ||
| // TODO: Do it in this object and forward objects to specific queues |
| } | ||
|
|
||
| // Remove operation from tracking | ||
| // TODO: Split two specific queues |
| return | ||
| } | ||
|
|
||
| // TODO: Split two specific queues |
|
|
||
| try? uploadsDatabase.writeTransaction { writableRealm in | ||
| for uploadFileId in batch { | ||
| // TODO: Split two specific queues |
| continue | ||
| } | ||
|
|
||
| // TODO: Split two specific queues |
| Log.uploadQueue("Done deleting all matching files for parentId:\(parentId)") | ||
| } | ||
|
|
||
| // TODO: Split between queues in sub PR |
| let frozenFileToDelete = toDeleteLive.freeze() | ||
| frozenFileToDelete.cleanSourceFileIfNeeded() | ||
|
|
||
| // TODO: Select correct upload queue |
|
This PR/issue depends on:
|
adrien-coye
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Strictly compatible refactor aiming at splitting the upload queues between
photoSyncand all other uploads.This PR is only the creation on an
UploadServiceand the creation of two dedicated queues.Here, all uploads are still performed in the same queue.
This PR Draft enables the photo sync on a separate queue
Service:
UploadServiceto centralise upload managementUploadServiceencapsulate twouploadQueue, one for photo sync and one globalUploadServiceexclusively, not in the queueQueues:
UploadQueueis focussed on queue related work, removed DB code.PhotoSyncUploadQueue, subclassingUploadQueuewill be dedicated to photo upload is a sub PR.Dependencies
Depends on #1471