Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bring back branch 5.1.2 into master #1443

Merged
merged 5 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 31 additions & 19 deletions kDrive/SceneDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate, AccountManagerDel
@LazyInjectService var backgroundTasksService: BackgroundTasksServiceable
@LazyInjectService var appNavigable: AppNavigable
@LazyInjectService var appRestorationService: AppRestorationServiceable
@LazyInjectService var deeplinkParser: DeeplinkParsable

var shortcutItemToProcess: UIApplicationShortcutItem?

Expand Down Expand Up @@ -68,20 +69,26 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate, AccountManagerDel
return
}

guard userActivity.activityType == SceneActivityIdentifier.mainSceneActivityType else {
Log.sceneDelegate("unsupported user activity type:\(userActivity.activityType)")
return
}
Task {
guard await !continueWebActivityIfPossible(scene, userActivity: userActivity) else {
return
}

scene.userActivity = userActivity
guard userActivity.activityType == SceneActivityIdentifier.mainSceneActivityType else {
Log.sceneDelegate("unsupported user activity type:\(userActivity.activityType)")
return
}

guard let userInfo = userActivity.userInfo else {
Log.sceneDelegate("activity has no metadata to process")
return
}
scene.userActivity = userActivity

guard let userInfo = userActivity.userInfo else {
Log.sceneDelegate("activity has no metadata to process")
return
}

Log.sceneDelegate("restore from \(userActivity.activityType)")
Log.sceneDelegate("selectedIndex:\(userInfo[SceneRestorationKeys.selectedIndex.rawValue])")
Log.sceneDelegate("restore from \(userActivity.activityType)")
Log.sceneDelegate("selectedIndex:\(userInfo[SceneRestorationKeys.selectedIndex.rawValue])")
}
}

private func prepareWindowScene(_ windowScene: UIWindowScene) {
Expand Down Expand Up @@ -217,11 +224,22 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate, AccountManagerDel
}

Task {
let success = await DeeplinkParser().parse(url: url)
let success = await deeplinkParser.parse(url: url)
Log.sceneDelegate("scene open url: \(url) success: \(success)")
}
}

@discardableResult
private func continueWebActivityIfPossible(_ scene: UIScene, userActivity: NSUserActivity) async -> Bool {
guard userActivity.activityType == NSUserActivityTypeBrowsingWeb,
let incomingURL = userActivity.webpageURL else {
Log.sceneDelegate("the scene continue userActivity - is not NSUserActivityTypeBrowsingWeb", level: .error)
return false
}

return await deeplinkParser.parse(url: incomingURL)
}

// MARK: - Handoff support

func scene(_ scene: UIScene, willContinueUserActivityWithType userActivityType: String) {
Expand All @@ -231,13 +249,7 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate, AccountManagerDel
func scene(_ scene: UIScene, continue userActivity: NSUserActivity) {
Log.sceneDelegate("scene continue userActivity")
Task {
guard userActivity.activityType == NSUserActivityTypeBrowsingWeb,
let incomingURL = userActivity.webpageURL else {
Log.sceneDelegate("scene continue userActivity - invalid activity", level: .error)
return
}

await UniversalLinksHelper.handleURL(incomingURL)
await continueWebActivityIfPossible(scene, userActivity: userActivity)
}
}

Expand Down
3 changes: 3 additions & 0 deletions kDriveCore/DI/FactoryService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ public enum FactoryService {
},
Factory(type: DeeplinkServiceable.self) { _, _ in
DeeplinkService()
},
Factory(type: DeeplinkParsable.self) { _, _ in
DeeplinkParser()
}
]
return services
Expand Down
4 changes: 4 additions & 0 deletions kDriveCore/Utils/DeeplinkParser.swift
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ public struct DeeplinkParser: DeeplinkParsable {
}

public func parse(url: URL) async -> Bool {
guard await !UniversalLinksHelper.handleURL(url) else {
return true
}

guard let components = URLComponents(url: url, resolvingAgainstBaseURL: true),
let params = components.queryItems else {
Log.sceneDelegate("Failed to open URL: Invalid URL", level: .error)
Expand Down
Loading