feat: MykSuite floating panel added #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambrdctr
force-pushed
the
mykSuite
branch
2 times, most recently
from
10270cd to
b8f6eba
Compare
adrien-coye
reviewed
Jan 29, 2025
| @@ -23,6 +23,10 @@ let package = Package( | |||
| targets: ["InfomaniakCoreSwiftUI"] | |||
| ), | |||
| .library( | |||
| name: "MyKSuite", | |||
| targets: ["MyKSuite"] | |||
There was a problem hiding this comment.
Shouldn't we have a standardisation of UI libraries ? like a MyKSuiteUI for instance ?
There was a problem hiding this comment.
It is a complete feature. So we have both UI code and logic code.
InfomaniakCoreUI is probably not the right place that.
Let's discuss it live
adrien-coye
requested changes
Jan 29, 2025
1 task
PhilippeWeidmann
force-pushed
the
mykSuite
branch
from
7be49e6 to
f2ac8d0
Compare
|
|
Moved to Infomaniak/ios-features#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kDrive UI PR Infomaniak/ios-kDrive#1409