-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SQL query with named parameters #94
Conversation
dd7a246
to
7546413
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 87.82% 87.93% +0.11%
==========================================
Files 15 15
Lines 813 829 +16
Branches 116 117 +1
==========================================
+ Hits 714 729 +15
Misses 44 44
- Partials 55 56 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, however on first usage got exceptions when the query was executed faster than the test data was written, apparently. I had to add a Thread.sleep
after write on a subsequent run to get results. However, I cannot now recreate this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably caused by "slow" propagation of the new measurement on the server side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass. However IOxExample had some timing issues on first use, which cannot now be recreated.
All other changes make sense.
Proposed Changes
This PR add supports for named parameters in the query API:
Checklist