Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from flight-grpc to flight-core #202

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

bednar
Copy link
Member

@bednar bednar commented Dec 5, 2024

Proposed Changes

The flight-grpc package is no longer maintained and was considered experimental, providing utility classes to expose both a Flight gRPC service and a client.

In our case, we don’t need to expose a gRPC service—the client alone is sufficient for our needs.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

The flight-grpc package is no longer maintained and was considered experimental, providing utility classes to expose both a Flight gRPC service and a client.

In our case, we don’t need to expose a gRPC service—the client alone is sufficient for our needs.
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (2d41c39) to head (7188b13).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files          17       17           
  Lines         903      903           
  Branches      137      137           
=======================================
  Hits          809      809           
  Misses         38       38           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review December 5, 2024 14:41
@bednar bednar requested a review from karel-rehor December 5, 2024 14:41
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Updates make sense.

@bednar bednar merged commit 86adf7e into main Dec 5, 2024
8 checks passed
@bednar bednar deleted the migrate-to-flight-core branch December 5, 2024 15:01
@bednar bednar added this to the 0.10.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants