Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused submodule QCBOR #2138

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Remove unused submodule QCBOR #2138

merged 1 commit into from
Oct 9, 2024

Conversation

NeroBurner
Copy link
Contributor

The submodule isn't used anymore. Remove the submodule reference completely.

@NeroBurner
Remove unused submodule QCBOR
ddd1397 
The submodule isn't used anymore. Remove the submodule reference
completely.
@NeroBurner NeroBurner added the maintenance Background work label Oct 6, 2024
@NeroBurner NeroBurner added this to the 1.15.0 milestone Oct 6, 2024
@NeroBurner NeroBurner mentioned this pull request Oct 6, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

Build size and comparison to main:

Section Size Difference
text 374512B -16B
data 948B 0B
bss 63488B 0B

mark9064
mark9064 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

mcuboot imgtool still relies on a python cbor library - not sure if this is used in practice either (it doesn't work without though and would need some code changes if it can be dropped)

@NeroBurner NeroBurner requested a review from a team October 7, 2024 06:33
FintasticMan
FintasticMan approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@FintasticMan FintasticMan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Since switching from the old weather service to the simple weather service we don't need this.

@NeroBurner NeroBurner merged commit 8598142 into main Oct 9, 2024
4 of 5 checks passed
@NeroBurner NeroBurner deleted the remove_unused_QCBOR branch October 9, 2024 18:26
jmlich pushed a commit to jmlich/InfiniTime that referenced this pull request Dec 22, 2024
@NeroBurner @jmlich
Remove unused submodule QCBOR (InfiniTimeOrg#2138)
fdf51e6 
The submodule isn't used anymore. Remove the submodule reference
completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FintasticMan FintasticMan FintasticMan approved these changes

@mark9064 mark9064 mark9064 approved these changes

Assignees
No one assigned
Labels
maintenance Background work
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NeroBurner @mark9064 @FintasticMan