Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowersleep: Improve algorithm by checking wrist angle #2014

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

FintasticMan
Copy link
Member

Inspired by @darkdragon-001 #827 (comment).

Checks if the user's wrist is pointing towards the floor, rather than only the amount of roll. It will turn off the display if the watch is angled at 60 degrees or more, and rotated at least 30 degrees within the last ~600ms.

Copy link

github-actions bot commented Feb 12, 2024

Build size and comparison to main:

Section Size Difference
text 373412B 240B
data 940B 0B
bss 63540B 24B

@tituscmd
Copy link
Contributor

Just for my understanding, is it actually optimal to check if the watch is facing the floor?
I would imagine the angle most people rest their watch at would be facing to their left, assuming they're wearing the watch on their left wrist.

@FintasticMan
Copy link
Member Author

Sorry for the confusion, this doesn't check if the screen is facing the floor, it checks if your wrist is pointing at the floor (or the ceiling, so that it also works for people who wear their watch on their right wrist).

@tituscmd
Copy link
Contributor

I see, that sounds good. Will definitely try it out soon!

@JF002 JF002 added this to the 1.15.0 milestone Mar 12, 2024
@JF002 JF002 merged commit f2df0c4 into InfiniTimeOrg:main Mar 12, 2024
7 checks passed
@FintasticMan FintasticMan deleted the improve_lower_sleep branch March 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants