Adds improvements to localization system #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rammba
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Hey @HalfOfBilly great work 🚀
I think localization is now more cleaner and easier to understand. I still don't like arrays in .json files but it's not a dealbreaker.
I've added just few suggestions.
|
|
||
| def update_project_settings(self) -> None: | ||
| project_godot_path = os.path.join(self.godot_project_path, 'project.godot') | ||
|
|
||
| if not os.path.exists(project_godot_path): | ||
| self.log_callback(get_localized(self.language, 'Console_Convertor_Settings_Error_GD_NotFound')) | ||
| self.log_callback(get_localized("Console_Error_MissingGodotFile")) | ||
| self.log_callback(get_localized("")) |
|
|
||
| def get_button(self, button_name): | ||
| return self.buttons.get(button_name.lower()) | ||
| return self.buttons.get(button_name)#.lower()) |
| def get_localized(language, key): | ||
| def get_localized(key): | ||
| # Find active language | ||
| with open('Current Language', 'r') as file: |
There was a problem hiding this comment.
I suppose this can cause slowness before we implement #57. I guess it's ok to have this approach for now.
| @@ -263,11 +262,29 @@ def insert_formatted(content): | |||
| text_widget.configure(state="disabled") | |||
|
|
|||
| def setup_conversion_settings(self): | |||
| settings = (set(item for sublist in get_localized(self.language, 'Settings_Categories_Contents') for item in sublist)) # merges all setting categories into a single array | |||
| #settings = (set(item for sublist in get_localized("Settings_Categories_Contents") for item in sublist)) # merges all setting categories into a single array | |||
|
|
||
| for idx, (label, command, icon) in enumerate(paths): | ||
| Game_Engine = get_localized(f"Menu_{label}") |
There was a problem hiding this comment.
You can rename label variable to engine_name?
|
Just as a reference, this is continuation of #56. @HalfOfBilly I like to reference old/previous PR/issue just in case when someone is going through git history to find what it's needed easier. |
Infiland
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisions to localization system as per @rammba 's feedback: