-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows specific getting started instructions #678
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #678 +/- ##
========================================
Coverage 94.60% 94.60%
========================================
Files 73 73
Lines 4800 4800
========================================
Hits 4541 4541
Misses 259 259 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !! :)
The tabs are very pretty! This is Gitbash only though? Wouldn't windows paths need |
This is all windows powershell (which is default installed right). I can change the path to be |
The installation via Where is the "checking paths work" section? |
There isn't one at present, but if a user installs Python and then Completely agree on the follow the windows official instructions, but there are details on adding the path that are on that page that we should point at. |
Wouldn't they ideally be installing python in a way that doesn't require them to add the path themselves though? (at least for current purposes) |
Are there obvious common ways that |
I hope adding this about the required python version and rec of pyenv/pyenv-win doesn't start to make this too unweildly. @vgro and I were just going through the installation while trying to run in static mode and found the python versioning a bit of a tricky one, especially for users unfamiliar with python, I think it's important to signpost them a bit. |
Removed reference to pyenv
Description
This PR adds Windows specific instructions for the "getting started page". This is done using tabs and can be seen here.
Type of change
Documentation improvement