Fixing broken links and typos in README. Closes #35 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd usually put the "closes #35" in the body of your message rather than the title. |
|
It looks good to me and normally I would approve this, but I'll leave it to @robewers01 to do a review so he can have the practice 😄 |
robewers01
reviewed
Jul 29, 2022
robewers01
approved these changes
Jul 29, 2022
|
@davidorme This has been approved, so you can merge it now! |
|
Ha, looks like you did it as I was typing my message 😆 |
|
Wasn't sure if the approver or requester does the merge :-) |
|
I'll work on #32 now. |
|
Usually it's the requester. As a reviewer you signal that you're happy with it by approving the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've disabled some markdownlint checks on the image lines (overlong and inline html). Controlling image sizes is a pain in markdown flavours, so I've used HTML as the more robust option.
Closes #35