-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.9 #356
Remove Python 3.9 #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Does it make sense to update the poetry.lock
as part of this PR? The minimum supported python version has changed, which means quite a lot of dependancies should now be less version constrained.
I've also found intersphinx
to be really annoying, and have no guess for the problem in this case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #356 +/- ##
===========================================
+ Coverage 95.94% 96.30% +0.35%
===========================================
Files 52 52
Lines 2614 2866 +252
===========================================
+ Hits 2508 2760 +252
Misses 106 106 ☔ View full report in Codecov by Sentry. |
Yes it really does. Good catch. I've updated |
Description
This PR is intended to remove Python 3.9. It adds
pyupgrade
to thepre-commit
hooks with a minimum Python version of 3.10 and that then made a bunch of changes automatically. These are mostly:set([1,2,3])
with the set literal{1,2,3}
Optional[int]
withint | None
The PR also:
pyproject.toml
topython = ">=3.10,<3.12"
, removing 3.9doc
dependencies, specifically to usemyst-nb = ^1.0.0
andsphinx = ^7.0.0
. This relates to Keep an eye onmyst-parser
andmyst-nb
updates #238 - we should now review that issue and update our Myst usage.poetry.lock
to update any packages that were being pinned at earlier versions by requiring 3.9.There are some minor doc updates to pass - including another ugly addition to sphinx's
nitpick-ignore
to tackle problems in the documentation ofvr.core.grid.GRID_STRUCTURE_SIG
. I've updated the way that type alias is created, butsphinx
is throwing errors. I think it believes the type alias (tuple[list[int], list[Polygon]]
is an actual tuple and is trying to document the__repr__
,count
andindex
methods? Those don't exist, so these have been added to nitpick ignore.Fixes #324
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks