Feature/vertical flow average

[vgro]

This PR changes the unit of the vertical flow in the data object from accumulated mm per time step (month) to mean mm per day. This is what the soil model needs as an input and it saved some conversions.

Fixes #347

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist

• Make sure you've run the pre-commit checks: $ pre-commit run -a
• All tests pass: $ poetry run pytest

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (235815d) 95.91% compared to head (a921f4a) 95.91%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
- Coverage    95.91%   95.91%   -0.01%     
===========================================
  Files           52       52              
  Lines         2596     2595       -1     
===========================================
- Hits          2490     2489       -1     
  Misses         106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jacobcook1995]

LGTM, just had a minor query. Also make sure to check that you are happy with my additions before you merge

[jacobcook1995]

Minor query, but why has this declined by a factor of 60 rather than a factor of 30?

[vgro]

Good point. This comes because the sum was calculated over both soil layers, so it's twice the amount of water (which was incorrect). I now also corrected a small mistake in the averaging as I didn't stack the daily values first. So the vertical flow in the data object represents only the flow through the top soil layer. Is that sensible or should I keep it two-dimensional and you select the topsoil index?

[jacobcook1995]

I think that seems sensible, I guess it makes sense to keep outputs simple unless someone needs a particular level of complexity