-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial plants model draft #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just had a few minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks overall very good, I added a few minor comments.
It would be useful if you could give your variables longer, more descriptive names. Please add tests for the plant_model
.
Codecov Report
@@ Coverage Diff @@
## develop #296 +/- ##
===========================================
- Coverage 97.55% 97.03% -0.53%
===========================================
Files 47 51 +4
Lines 2171 2293 +122
===========================================
+ Hits 2118 2225 +107
- Misses 53 68 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@vgro I was holding off on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A few minor comments :-)
Haha, yes, annoyingly (and luckily) it always does ;-) |
Description
This PR provides the first steps in setting up the
plants
model. The functionality in this PR is purely focussed on the initial setup of the plant community:Plants
class is defined to hold lists ofPlantCohort
s by grid cell and to populate that from provided init data, which is basically just a data frame of plant cohort details.The next steps for future PRs are to:
update
method to estimate productivity, allocation to growth and hence a new canopy model, but this is not likely to happen soon.Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks